This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/2.1] Fix opt data for source build#17268
Merged
weshaggard merged 3 commits intoMar 27, 2018
Merged
Conversation
Pass unprocessed args to restore optdata step so it can override the sources when doing restore Handle prority as an unprocessed arg for the sync alias
There were various restore targets happening independently when they should all be combined so the sync step can be independent from the build step. This change merges them together under the Sync target. In particular this moves RestoreOptData and RestoreNETCorePlatforms to be part of the sync step instead of being individually ran. Pass BuildType to sync commands so optdata gets restored correctly
We don't need the binclash logger for optdata so disable it by pass a single space (note empty string means default). The default value points at net46 which isn't what we want on linux.
weshaggard
changed the title
Member
|
@weshaggard Is this related at all to #17262? |
Member
Author
No it isn't related. This is more about enabling us to pull the PGO data packages from local package folder for source-build. |
michellemcdaniel
approved these changes
Mar 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port #17136 and #17226 to release/2.1 branch to fix source-build.
FYI @dseefeld @dagood
cc @RussKeldorph @jashook