This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix Dictionary CopyTo regression#17300
Merged
Merged
Conversation
stephentoub
approved these changes
Mar 28, 2018
Member
|
The + i caused worse codegen? |
Member
Author
Better codegen, but items could be skipped when |
dotnet-bot
pushed a commit
to dotnet/corert
that referenced
this pull request
Mar 28, 2018
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Mar 29, 2018
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Mar 30, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Mar 30, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Mar 30, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Member
|
@Anipik This was missed by the CoreCLR->CoreFX mirror. |
Member
Author
|
Think there were 3 that had it but they weren't merged dotnet/corefx#28632, dotnet/corefx#28633, dotnet/corefx#28634 |
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Mar 31, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
|
@jkotas @benaadams I was testing something with mirror and somehow skipped this PR. I have started the Pr for it |
Anipik
pushed a commit
to dotnet/corefx
that referenced
this pull request
Apr 1, 2018
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
MichalStrehovsky
pushed a commit
to MichalStrehovsky/corert
that referenced
this pull request
Apr 6, 2018
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also List set version
/cc @jkotas @stephentoub