This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Added a new API to provide memory information that GC records#17326
Merged
Conversation
is to be used by BCL for deciding when to trim memory usage in pooling code
sywhang
approved these changes
Mar 29, 2018
|
Is this all that's necessary for the array pool work? |
davmason
approved these changes
Mar 29, 2018
Member
Author
|
@davmason yes. array pool is actually not using all the info 'cause it doesn't currently track the sizes in the pool. should it track that in the future it could use all the info. strictly speaking, I also checked in #17177 which helps with trimming for 32-bit processes that run on machines with more physical mem than VM but that's applicable to more than just array pool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to be used by BCL for deciding when to trim memory usage in pooling
code.