This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Re-enable arg assert in scanArgRegTable#17442
Closed
CarolEidt wants to merge 1 commit into
Closed
Conversation
This assert was formerly enabled only for the "full arg info case", i.e. when there was not a frame on x86. WIth PR dotnet#10782 the sense of the first condition was inadvertently changed. With PR dotnet#17363 the tracking of `argCnt` vs. `argHigh` was fixed so that the assert is correct for the "partial arg info" case. The first condition should be removed to make it cover the "full argo info case" as well (as before dotnet#10782).
Author
|
test Windows_NT x86 Checked gcstress0xc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This assert was formerly enabled only for the "full arg info case", i.e. when there was not a frame on x86. WIth PR #10782 the sense of the first condition was inadvertently changed. With PR #17363 the tracking of
argCntvs.argHighwas fixed so that the assert is correct for the "partial arg info" case.The first condition should be removed to make it cover the "full argo info case" as well (as before #10782).