Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Initialize Compiler::Vector128/256ULongHandle in compInit#17697

Merged
CarolEidt merged 1 commit into
dotnet:masterfrom
mikedn:vec-hnd
Apr 24, 2018
Merged

Initialize Compiler::Vector128/256ULongHandle in compInit#17697
CarolEidt merged 1 commit into
dotnet:masterfrom
mikedn:vec-hnd

Conversation

@mikedn
Copy link
Copy Markdown

@mikedn mikedn commented Apr 20, 2018

Failure to initialize these members can lead to bad code generation as described in #15011 (comment)

@danmoseley danmoseley added this to the 2.1.0 milestone Apr 20, 2018
@danmoseley
Copy link
Copy Markdown
Member

Tentatively marking 2.1 per comments

@mikedn
Copy link
Copy Markdown
Author

mikedn commented Apr 21, 2018

Ubuntu x64 build failed due to lack of disk space, retrying

@dotnet-bot test Ubuntu x64 Checked Innerloop Build and Test

@fiigii
Copy link
Copy Markdown

fiigii commented Apr 24, 2018

@CarolEidt @AndyAyersMS Could you please take a look at this PR when you get a chance?

@mikedn Thank you for the work!

Copy link
Copy Markdown

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@CarolEidt CarolEidt merged commit 359f320 into dotnet:master Apr 24, 2018
@mikedn mikedn deleted the vec-hnd branch September 28, 2019 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants