This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add public implementation WindowsRuntimeResourceManagerBase#18417
Merged
Conversation
jkotas
reviewed
Jun 11, 2018
| // | ||
| // This is implemented in System.Runtime.WindowsRuntime as function System.Resources.WindowsRuntimeResourceManager, | ||
| // allowing us to ask for a WinRT-specific ResourceManager. | ||
| // It is important to have WindowsRuntimeResourceManagerBase as regular class with virtual methods and default implementations. |
Member
There was a problem hiding this comment.
This comment does not match the implementation. The comment stays that it is important to not have the class abstract; but the implementation is actually abstract.
Member
There was a problem hiding this comment.
I think it is fine to keep them abstract since we plan to always ship them together.
Member
|
other than @jkotas comment, LGTM |
tarekgh
approved these changes
Jun 11, 2018
jkotas
reviewed
Jun 11, 2018
|
|
||
| namespace Internal.Resources | ||
| { | ||
| // This is implemented in System.Runtime.WindowsRuntime as function System.Resources.WindowsRuntimeResourceManager, |
Member
There was a problem hiding this comment.
Nit: System.Resources.WindowsRuntimeResourceManager is not a function.
jkotas
approved these changes
Jun 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change is to add public implementation WindowsRuntimeResourceManagerBase and PRIExceptionInfo in S.P.Corelib for S.P.WindowsRuntime to use. It will help to remove [assembly: InternalsVisibleTo(S.R.WindowsRuntime) ] in S.P.Corelib later.