This repository was archived by the owner on Jan 23, 2023. It is now read-only.
fix the desktop build break#18475
Merged
Merged
Conversation
|
Looks like this was changed in lsraarm.cpp while I was working on that change. Can you add the dstCount that was added in lsraarm.cpp as well. |
|
Thank you for fixing this |
|
Thanks @sandreenko and @jashook, and sorry I didn't respond quickly to the request for review. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* fix desktop build break after dotnet/coreclr#18346 * add dstCount Commit migrated from dotnet/coreclr@793dadd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced by #18346.
BuildPutArgSplitreturnsThe number of sources consumed by this node., so looks like it should go intosrcCount.The warning was:
lsraarm64.cpp(811): warning C4701: potentially uninitialized local variable 'srcCount' used.After I merge PR #18318 I will try to sync the list of warnings enabled on desktop with CoreCLR to prevent such breaks.
PTAL @dotnet/jit-contrib