This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Correctly return early if the StructABI test fails#18529
Merged
Conversation
jashook
changed the title
BruceForstall
suggested changes
Jun 18, 2018
BruceForstall
left a comment
BruceForstall
left a comment
There was a problem hiding this comment.
That would work, but it also fails when at the failure of the first test. I would prefer all tests run (and possibly fail), and the final return code be -1 if any test fails.
E.g.,
bool allOk = true;
ok = case1();
if (!ok) allOk = false;
ok = case2();
if (!ok) allOk = false;
etc.
or, more simply,
ok = true;
if (!case1()) ok = false;
if (!case2()) ok = false;
...
Author
|
Ok will make the change. |
jashook
force-pushed
the
fix_struct_abi_test
branch
from
f798371 to
b8b349c
Compare
Author
|
@BruceForstall ptal |
BruceForstall
approved these changes
Jun 18, 2018
janvorli
reviewed
Jun 19, 2018
| ok = EnoughRegistersSysV3Wrapper(); | ||
| ok = EnoughRegistersSysV4Wrapper(); | ||
|
|
||
| if (!EchoSingleByteWrapper()) ok = false; |
Member
There was a problem hiding this comment.
A nit - how about just ok &= EchoSingleLongWrapper(); etc?
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/coreclr@a74bbaf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@BruceForstall ptal