Build managed tests with dotnet#19254
Conversation
…ng individual test exe builds to fail
|
@dotnet-bot test Windows_NT x64 Checked please |
|
@dotnet-bot test Windows_NT x86 Checked Build and Test |
|
@chsienki Looks like the arm64 release pri-1 builds are failing all the pri-1 tests. From what I can tell, the pri-1 tests are not getting built, even though I do see "-priority=1" in various places in the build log. Any ideas? https://ci.dot.net/job/dotnet_coreclr/job/master/view/arm64/job/arm64_cross_release_windows_nt_flow/ The thing is that arm32/arm64 use a different test list, that explicitly lists all tests to run. I'm worried that what could happen to the other architectures is that we pass "-priority=1" but for some reason we don't actually build pri-1 tests, and we don't notice that because when we run tests, we only run what we find. |
|
In fact, this appears to be what has happened: The last x64 checked Windows NT pri-1 job that runs on every merge, before your change: https://ci.dot.net/job/dotnet_coreclr/job/master/view/x64/job/checked_windows_nt/10089/consoleText After your change: https://ci.dot.net/job/dotnet_coreclr/job/master/view/x64/job/checked_windows_nt/10092/consoleText You can also see that the time these jobs are taking has dropped from almost 2 hours to under 1 hour. |
|
@chsienki Seeing as how this is going to break arm32/arm64 pri-1 Windows testing, and cause us to silently lose coverage everywhere else, and how it's the weekend, I'm going to revert this. |
This reverts commit 101baee.
|
Revert with: #19287 |
Revert "Build managed tests with dotnet (#19254)"
|
Dang, ok thanks @BruceForstall. I'll take a look and see if we can eventually get this in without breaking everything. |
This reverts commit c8480f5.
* Revert "Revert "Build managed tests with dotnet (#19254)"" * Reenable MSBuild support through dotnet instead of global MSBuild
3 participants
This is a re-PR of #19230 as the previous one broke the priority flag, which is fixed here.