This repository was archived by the owner on Jan 23, 2023. It is now read-only.
WIP Update base services tests to SDK style projects#19282
Closed
chsienki wants to merge 1 commit into
Closed
Conversation
chsienki
added
* NO MERGE *
chsienki
force-pushed
the
upgrade_test_projects_sdk
branch
from
f61ef13 to
c80ef42
Compare
Member
Author
|
@dotnet-bot test Windows_NT x86 Checked Build and Test |
4creators
reviewed
Aug 3, 2018
| </ItemGroup> | ||
| <ItemGroup> | ||
| <ProjectReference Include="StringThrower.ilproj" /> | ||
| <NoWarn Include="42016,42020,42025,42024" /> |
There was a problem hiding this comment.
That's wrong semantics as all upper level NoWarn settings are lost - should be
<NoWarn Include="42016,42020,42025,42024,$(NoWarn)" />I know that it is old code but perhaps you could fix it with some freecycles, or not 😄
4creators
reviewed
Aug 3, 2018
| <Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <ProjectReference Include="../../../Common/CoreCLRTestLibrary/CoreCLRTestLibrary.csproj" /> |
4creators
reviewed
Aug 3, 2018
| <Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <ProjectReference Include="../../../Common/CoreCLRTestLibrary/CoreCLRTestLibrary.csproj" /> |
Member
|
Hey @chsienki, what's the status on this? I would really love to see this going into master. |
ViktorHofer
reviewed
Aug 29, 2018
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|x64'"> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x64'"></PropertyGroup> |
Member
There was a problem hiding this comment.
with the project-sdk csproj format you don't need these anymore. Instead we should use the Configurations property, i.e. https://github.com/dotnet/corefx/blob/master/src/System.Text.RegularExpressions/src/System.Text.RegularExpressions.csproj#L9
Member
|
Closing stale PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update all the tests in baseservices to be SDK style projects