This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix test for GT_INDEX_ADDR to forcibly compile with minopts#20203
Merged
Conversation
Update test introduced in dotnet#20047 so that the key method `ReadBytes` is compiled with minopts by default.
Member
Author
|
@briansull PTAL Somewhat surprisingly a method marked as This is a consequence of the way that no optimization info is passed to the jit -- via jit flags rather than by checking the method impl attributes. (Will port this over to 2.2 as well, to fix up the copy of the test added via #20127) |
briansull
approved these changes
Oct 2, 2018
Member
Author
|
Just a test update, so am going to ignore unrelated failures and legs that never finish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update test introduced in #20047 so that the key method
ReadByteis compiledwith minopts by default.