This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Move BinaryPrimitives into coreclr shared source#20288
Merged
Merged
Conversation
jkotas
approved these changes
Oct 5, 2018
ahsonkhan
approved these changes
Oct 5, 2018
Member
|
@Anipik The mirror is not picking up this PR. Could you please take a look? |
dotnet-maestro-bot
pushed a commit
to dotnet-maestro-bot/corefx
that referenced
this pull request
Oct 6, 2018
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
dotnet-maestro-bot
pushed a commit
to dotnet-maestro-bot/corert
that referenced
this pull request
Oct 6, 2018
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
|
i am sure about the reason behind why the mirror was snot picking the change. But restarting it did the trick :) |
stephentoub
pushed a commit
to dotnet/corefx
that referenced
this pull request
Oct 6, 2018
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Oct 6, 2018
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
A-And
pushed a commit
to A-And/coreclr
that referenced
this pull request
Nov 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This supports the BSWAP intrinsic work at #18398.)
This is the coreclr PR to move
BinaryPrimitivesinto System.Private.CoreLib.dll. It'll be followed up with a corefx PR that fixes up the System.Memory.dll source.No new API is being added by this PR. System.Memory.dll will continue to be the façade which exposes this type through its ref surface.