Masun dev

[maggiemsft]

This change implements string trim char and try to solve issue discussed in https://github.com/dotnet/coreclr/issues/1826
Appreciate comments and review
This is also the bootcamp assignment
cc: @ellismg @sneshaf @Anniepoh

[dnfclas]

Hi @maggiemsft, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

[dnfclas]

@maggiemsft, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

[justinvp]

Should the parameter be named trimChar to be consistent with the existing trimChars?

[maggiemsft]

Agreed. Should I submit a new change and PR for it?

[ellismg]

You can just create a new commit (or amend the existing one) and then push the new changes to GitHub. You don't need to create a new PR.

[justinvp]

@ellismg, if this PR can go in coreclr master, can we also go ahead and merge #895 in coreclr master? Then submit a separate PR against corefx future to actually expose the APIs in the reference assembly?

[jkotas]

Dup of #2070