Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Implement AVX2.BroadcastScalarToVector128/256#20579

Merged
CarolEidt merged 2 commits into
dotnet:masterfrom
fiigii:broadcast
Oct 26, 2018
Merged

Implement AVX2.BroadcastScalarToVector128/256#20579
CarolEidt merged 2 commits into
dotnet:masterfrom
fiigii:broadcast

Conversation

@fiigii
Copy link
Copy Markdown

@fiigii fiigii commented Oct 24, 2018

This PR

tannergooding
tannergooding reviewed Oct 24, 2018
View reviewed changes
Comment thread tests/src/JIT/HardwareIntrinsics/X86/Avx/BroadcastScalarToVector256.Double.cs Outdated
tannergooding
tannergooding approved these changes Oct 24, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For the tests, I just checked GenerateTests.csx and the new template.

@fiigii
Copy link
Copy Markdown
Author

fiigii commented Oct 24, 2018

@dotnet-bot test Windows_NT x64 Checked jitx86hwintrinsicnoavx
@dotnet-bot test Windows_NT x64 Checked jitx86hwintrinsicnoavx2
@dotnet-bot test Windows_NT x64 Checked jitnox86hwintrinsic
@dotnet-bot test Windows_NT x86 Checked jitx86hwintrinsicnoavx
@dotnet-bot test Windows_NT x86 Checked jitx86hwintrinsicnoavx2
@dotnet-bot test Windows_NT x86 Checked jitnox86hwintrinsic
@dotnet-bot test Ubuntu x64 Checked jitx86hwintrinsicnoavx
@dotnet-bot test Ubuntu x64 Checked jitx86hwintrinsicnoavx2
@dotnet-bot test Ubuntu x64 Checked jitnox86hwintrinsic

@fiigii
Copy link
Copy Markdown
Author

fiigii commented Oct 24, 2018

@CarolEidt PTAL

@fiigii
Copy link
Copy Markdown
Author

fiigii commented Oct 24, 2018

@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test
@dotnet-bot test Ubuntu arm Cross Checked no_tiered_compilation_innerloop Build and Test

@CarolEidt
Copy link
Copy Markdown

CarolEidt commented Oct 24, 2018

AVX2 is fully implemented now.

Yay!

@fiigii
Copy link
Copy Markdown
Author

fiigii commented Oct 24, 2018

Some CI jobs failed on JIT_superpmi._superpmicollect_superpmicollect_._superpmicollect_superpmicollect_cmd. It seems unrelated?

CarolEidt
CarolEidt approved these changes Oct 24, 2018
View reviewed changes
Copy link
Copy Markdown

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just some comment suggestions.

Comment thread src/jit/gentree.cpp Outdated
Comment thread src/jit/gentree.cpp
Comment thread src/jit/hwintrinsiclistxarch.h
@CarolEidt
Copy link
Copy Markdown

CarolEidt commented Oct 25, 2018

Some CI jobs failed on JIT_superpmi.superpmicollect_superpmicollect._superpmicollect_superpmicollect_cmd. It seems unrelated?

They don't seem to be failing on other legs. It would probably be worth running them again, as there have been some hickups in CI,.

@fiigii
Copy link
Copy Markdown
Author

fiigii commented Oct 25, 2018

@dotnet-bot test Windows_NT x64 Checked jitx86hwintrinsicnoavx
@dotnet-bot test Windows_NT x64 Checked jitx86hwintrinsicnoavx2
@dotnet-bot test Windows_NT x64 Checked jitnox86hwintrinsic
@dotnet-bot test Windows_NT x86 Checked jitx86hwintrinsicnoavx
@dotnet-bot test Windows_NT x86 Checked jitx86hwintrinsicnoavx2
@dotnet-bot test Windows_NT x86 Checked jitnox86hwintrinsic
@dotnet-bot test Ubuntu x64 Checked jitx86hwintrinsicnoavx
@dotnet-bot test Ubuntu x64 Checked jitx86hwintrinsicnoavx2
@dotnet-bot test Ubuntu x64 Checked jitnox86hwintrinsic

@fiigii
Copy link
Copy Markdown
Author

fiigii commented Oct 25, 2018

@CarolEidt I have addressed all the feedback and CI gets green. Can we merge this PR?

@CarolEidt CarolEidt merged commit a73bfb8 into dotnet:master Oct 26, 2018
@fiigii fiigii deleted the broadcast branch October 26, 2018 03:23
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@CarolEidt
Merge pull request dotnet/coreclr#20579 from fiigii/broadcast
16d239d 
 Implement AVX2.BroadcastScalarToVector128/256

Commit migrated from dotnet/coreclr@a73bfb8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@CarolEidt CarolEidt CarolEidt approved these changes

@tannergooding tannergooding tannergooding approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fiigii @CarolEidt @tannergooding @FeiPengIntel