This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Remove SSE4.2 STTNI APIs for .NET Core 3.0#20887
Merged
Merged
Conversation
Member
|
I don't think we need to remove them here, only in the reference assembly in CoreFX (much as we did for 2.1). |
Author
|
@tannergooding These STTNI APIs are already out-of-date, the future discussion will base on the current design #19958 |
Author
|
cc @stephentoub |
Member
|
Thanks @fiigii |
dotnet-maestro-bot
pushed a commit
to dotnet-maestro-bot/corefx
that referenced
this pull request
Nov 12, 2018
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub
pushed a commit
to dotnet/corefx
that referenced
this pull request
Nov 12, 2018
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
dotnet-maestro-bot
pushed a commit
to dotnet-maestro-bot/corert
that referenced
this pull request
Nov 13, 2018
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
MichalStrehovsky
pushed a commit
to dotnet/corert
that referenced
this pull request
Nov 13, 2018
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jlennox
pushed a commit
to jlennox/corefx
that referenced
this pull request
Dec 16, 2018
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the last API review meeting, we did not get a consensus for SSE4.2 STTNI (string processing) intrinsic APIs. So, we decided to leave these instructions for the next review/version, which we may get more suggestions/demands to find a better approach to expose these STTNI instructions (e.g., higher-level Unicode string APIs, etc.)
This PR remove the original SSE4.2 STTNI APIs to make Intel HW intrinsic ready for .NET Core 3.0.
@CarolEidt @tannergooding @eerhardt @terrajobst @GrabYourPitchforks