Adding missing overloads of the Sse2 and Sse41 Extract methods#21197
Adding missing overloads of the Sse2 and Sse41 Extract methods#21197tannergooding wants to merge 1 commit into
Conversation
|
CC. @fiigii, @CarolEidt, @eerhardt |
| /// int _mm_extract_epi8 (__m128i a, const int imm8) | ||
| /// PEXTRB reg/m8, xmm, imm8 | ||
| /// </summary> | ||
| public static byte Extract(Vector128<sbyte> value, byte index) => Extract(value, index); |
There was a problem hiding this comment.
should this be public static sbyte Extract?
|
This is intentional #17637 |
| /// int _mm_extract_epi8 (__m128i a, const int imm8) | ||
| /// PEXTRB reg/m8, xmm, imm8 | ||
| /// </summary> | ||
| public static byte Extract(Vector128<sbyte> value, byte index) => Extract(value, index); |
There was a problem hiding this comment.
(super nit) - all the other overloads has the "signed" version listed first, then the "unsigned" version. Do we want to keep it consistent to have the signed version first here?
Ah, right. I forgot about that.... I encountered this when trying to implement the |
Yes, but it is caused by the hardware feature... |
Right. The current issue is that However, we should probably also explicitly discuss and get an official API decision (as we've done with the other cases so far) on what we want to do here:
|
|
Closing this and opened https://github.com/dotnet/corefx/issues/33696 |
3 participants
We were missing the signed overloads of a few of these methods.