This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add repro for (reg2 == REG_NEXT(reg1)) || (reg2 == REG_LR) assert in codegenarm64.#21344
Merged
Conversation
Author
sandreenko
changed the title
CodeGen::genSaveCalleeSavedRegistersHelp.(reg2 == REG_NEXT(reg1)) || (reg2 == REG_LR) assert in codegenarn64.
sandreenko
changed the title
(reg2 == REG_NEXT(reg1)) || (reg2 == REG_LR) assert in codegenarn64.(reg2 == REG_NEXT(reg1)) || (reg2 == REG_LR) assert in codegenarm64.
Author
|
PTAL @BruceForstall @dotnet/jit-contrib |
briansull
approved these changes
Dec 4, 2018
BruceForstall
approved these changes
Dec 5, 2018
sandreenko
force-pushed
the
FixDevDiv_736188
branch
from
dc403a4 to
c7ded63
Compare
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…n `codegenarm64`. (dotnet/coreclr#21344) * Add a repro. * Exclude the failing test. * fix formatting Commit migrated from dotnet/coreclr@5e6cefa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds test for #21363.
The desktop issue is 736188.
These functions need some refactoring before I can push the fix so I want to do it in separate PRs.