Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

strlen to managed code and vectorize#21729

Merged
jkotas merged 4 commits into
dotnet:masterfrom
benaadams:strlen
Jan 2, 2019
Merged

strlen to managed code and vectorize#21729
jkotas merged 4 commits into
dotnet:masterfrom
benaadams:strlen

Conversation

@benaadams
Copy link
Copy Markdown
Member

@benaadams benaadams commented Dec 31, 2018

@benaadams benaadams mentioned this pull request Dec 31, 2018
@jkotas
Copy link
Copy Markdown
Member

jkotas commented Dec 31, 2018

Build breaks ... this needs updating in https://github.com/dotnet/coreclr/blob/master/src/vm/mscorlib.h#L957 too. Change SM_PtrSByt_RetInt to SM_PtrByte_RetInt and also make the matching change for SM_PtrSByt_RetInt in metasig.h.

Comment thread src/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.cs Outdated
Comment thread src/System.Private.CoreLib/src/System/StubHelpers.cs Outdated
Comment thread src/System.Private.CoreLib/src/System/StubHelpers.cs Outdated
@jkotas
Copy link
Copy Markdown
Member

jkotas commented Dec 31, 2018

You can replace Win32Native.lstrlenA and Win32Native.lstrlenW` with the managed implementation too while you are on it.

@benaadams
Copy link
Copy Markdown
Member Author

Will do a follow up PR for lstrlenW and wcslen

@benaadams benaadams mentioned this pull request Dec 31, 2018
Comment thread src/System.Private.CoreLib/shared/System/String.cs Outdated
Comment thread src/System.Private.CoreLib/shared/System/String.cs
Comment thread src/System.Private.CoreLib/shared/System/String.cs
Comment thread src/System.Private.CoreLib/src/System/StubHelpers.cs Outdated
Copy link
Copy Markdown
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas
Copy link
Copy Markdown
Member

jkotas commented Jan 1, 2019

@dotnet-bot test Ubuntu x64 Checked CoreFX Tests please
@dotnet-bot test Windows_NT x64 Checked CoreFX Tests please

@benaadams
Copy link
Copy Markdown
Member Author

👍

@jkotas jkotas merged commit 4a7a204 into dotnet:master Jan 2, 2019
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corefx that referenced this pull request Jan 2, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corert that referenced this pull request Jan 2, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas pushed a commit to dotnet/corefx that referenced this pull request Jan 2, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas pushed a commit to dotnet/corert that referenced this pull request Jan 2, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/mono that referenced this pull request Jan 2, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
marek-safar pushed a commit to mono/mono that referenced this pull request Jan 2, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
@benaadams benaadams deleted the strlen branch January 9, 2019 23:49
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants