Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Mirror changes from dotnet/corert,corefx#22196

Merged
jkotas merged 1 commit into
dotnet:masterfrom
Dotnet-GitSync-Bot:mirror-merge-10028089
Jan 25, 2019
Merged

Mirror changes from dotnet/corert,corefx#22196
jkotas merged 1 commit into
dotnet:masterfrom
Dotnet-GitSync-Bot:mirror-merge-10028089

Conversation

@Dotnet-GitSync-Bot
Copy link
Copy Markdown

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot commented Jan 24, 2019

This PR contains mirrored changes from dotnet/corert,corefx

Please REBASE this PR when merging

cc @filipnavara

…t#6887)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
@jkotas jkotas merged commit 71d3187 into dotnet:master Jan 25, 2019
@filipnavara
Copy link
Copy Markdown
Member

@karelz What's the process for labeling something with netfx-port-consider? This is broken on NetFX as shown by unit tests in dotnet/corefx#34818.

@karelz
Copy link
Copy Markdown
Member

karelz commented Jan 31, 2019

@filipnavara we do not use that label anymore. I was planning to delete it eventually.
We will consider porting bug fixes which have high business impact on customers (either large number of customers, or significant segment of customers) without reasonable workaround to .NET Framework. That can be done ad-hoc.
If you are adding test and it fails on .NET Framework, first make sure it is truly bug in .NET Framework (and not in .NET Core or in the test), then disable the test on .NET Framework.

@filipnavara
Copy link
Copy Markdown
Member

If you are adding test and it fails on .NET Framework, first make sure it is truly bug in .NET Framework (and not in .NET Core or in the test),

I checked with reference source it is exactly the same bug that was fixed in CoreCLR.

then disable the test on .NET Framework.

Done.

The impact for customers is likely minimal and there are workarounds so it's not likely to meet the bar for backport, but I wanted to check nevertheless.

@karelz
Copy link
Copy Markdown
Member

karelz commented Jan 31, 2019

Thanks @filipnavara! I love it when people ask for not-quite-certain-things first ... IMO a very good practice ;)

picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants