This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Move Timer to shared CoreLib partition.#22231
Merged
Merged
Conversation
filipnavara
commented
Jan 26, 2019
jkotas
reviewed
Jan 27, 2019
jkotas
reviewed
Jan 27, 2019
…de out of SetTimer in non-shared code.
filipnavara
changed the title
jkotas
reviewed
Jan 27, 2019
Member
|
LGTM otherwise. Thank you! |
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Jan 27, 2019
* Move Timer to shared CoreLib partition. * Move SignalNoCallbacksRunning back to shared code, add static EventWaitHandle.Set. * Remove AppDomain references from shared Timer code, reshuffle some code out of SetTimer in non-shared code. * Change m_ prefix to match code style. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Jan 27, 2019
* Move Timer to shared CoreLib partition. * Move SignalNoCallbacksRunning back to shared code, add static EventWaitHandle.Set. * Remove AppDomain references from shared Timer code, reshuffle some code out of SetTimer in non-shared code. * Change m_ prefix to match code style. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/mono
that referenced
this pull request
Jan 27, 2019
* Move Timer to shared CoreLib partition. * Move SignalNoCallbacksRunning back to shared code, add static EventWaitHandle.Set. * Remove AppDomain references from shared Timer code, reshuffle some code out of SetTimer in non-shared code. * Change m_ prefix to match code style. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 27, 2019
* Move Timer to shared CoreLib partition. * Move SignalNoCallbacksRunning back to shared code, add static EventWaitHandle.Set. * Remove AppDomain references from shared Timer code, reshuffle some code out of SetTimer in non-shared code. * Change m_ prefix to match code style. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Jan 27, 2019
* Move Timer to shared CoreLib partition. * Move SignalNoCallbacksRunning back to shared code, add static EventWaitHandle.Set. * Remove AppDomain references from shared Timer code, reshuffle some code out of SetTimer in non-shared code. * Change m_ prefix to match code style. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
marek-safar
pushed a commit
to mono/mono
that referenced
this pull request
Jan 27, 2019
* Move Timer to shared CoreLib partition. * Move SignalNoCallbacksRunning back to shared code, add static EventWaitHandle.Set. * Remove AppDomain references from shared Timer code, reshuffle some code out of SetTimer in non-shared code. * Change m_ prefix to match code style. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Move Timer to shared CoreLib partition. * Move SignalNoCallbacksRunning back to shared code, add static EventWaitHandle.Set. * Remove AppDomain references from shared Timer code, reshuffle some code out of SetTimer in non-shared code. * Change m_ prefix to match code style. Commit migrated from dotnet/coreclr@307ec0b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #21932.
I'll submit CoreRT counter-part PR soon, still working on getting the Unix build working.