This repository was archived by the owner on Jan 23, 2023. It is now read-only.
JIT: fix ifdef guarding an assert#22460
Merged
Merged
Conversation
We use `_TARGET_AMD64_`, not `_TARGET_X64_`.
Member
Author
|
Just something I randomly noticed...split off from early version of #22454 @BruceForstall PTAL |
|
Sorry, I should have mentioned in my comment that I already cleaned up that code in #21711 so probably this isn't needed (though it will take a bit more for that PR to get out of WIP). |
BruceForstall
approved these changes
Feb 7, 2019
BruceForstall
left a comment
BruceForstall
left a comment
There was a problem hiding this comment.
Thanks!
You should trigger pri-1 x64 jobs, maybe including a couple stress, just to make sure the assert doesn't fire.
Member
Author
|
@dotnet-bot test Windows_NT x64 Checked Build and Test |
Member
Author
|
Might as well take this even if it may be shortly obsoleted.... |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
We use `_TARGET_AMD64_`, not `_TARGET_X64_`. Commit migrated from dotnet/coreclr@76c322d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use
_TARGET_AMD64_, not_TARGET_X64_.