This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Move EventCounter back to System.Private.CoreLib#22475
Closed
sywhang wants to merge 1 commit into
Closed
Conversation
Member
|
The better way to do this would be to:
Doing it this way is better for following the history. Here is a recent example how this was done: dotnet/corefx#34654 |
Author
|
Ok. I'll start by submitting a PR to CoreFX first then. Thanks @jkotas! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR that addresses #20372.
FYI this branch - https://github.com/sywhang/coreclr/tree/add-runtime-perfcounters - contains all the changes I've made so far, but I'm breaking things up into smaller PRs so that they can be more easily reviewed.
cc @tommcdon @shirhatti