Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Remove GTF_REVERSE_OPS checks from LSRA#22489

Merged
CarolEidt merged 1 commit into
dotnet:masterfrom
mikedn:lsra-no-reverse
Jul 22, 2019
Merged

Remove GTF_REVERSE_OPS checks from LSRA#22489
CarolEidt merged 1 commit into
dotnet:masterfrom
mikedn:lsra-no-reverse

Conversation

@mikedn
Copy link
Copy Markdown

@mikedn mikedn commented Feb 8, 2019

GTF_REVERSE_OPS is cleared during rationalization.

Pulled out of #21711 as that's way too large.

GTF_REVERSE_OPS is cleared during rationalization.
@mikedn
Copy link
Copy Markdown
Author

mikedn commented Feb 8, 2019

@CarolEidt Seems like there's not a lot to remove for #16528, unless I'm missing something.

@sandreenko
Copy link
Copy Markdown

LGTM
cc @dotnet/jit-contrib

Copy link
Copy Markdown

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@CarolEidt CarolEidt merged commit 2a8529c into dotnet:master Jul 22, 2019
@mikedn
Copy link
Copy Markdown
Author

mikedn commented Jul 23, 2019

Thanks, should #16528 be closed? I can't find anything else reverse ops related in LSRA/backend. CodeGen's genCreateAddrMode still uses it but that's needed because is called early, from gtSetEvalOrder.

@mikedn mikedn deleted the lsra-no-reverse branch July 23, 2019 05:27
@CarolEidt
Copy link
Copy Markdown

should #16528 be closed

Yes, I meant to respond to that (and close it) - closed it now. Thanks!

picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
GTF_REVERSE_OPS is cleared during rationalization.

Commit migrated from dotnet/coreclr@2a8529c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants