-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Do not include unnecessary files in build #2320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This highlighted a mismatch between the old msbuild-based scripts and CMakefiles. This should be left in and FEATURE_LAZYCOW defined for x86 and arm instead (on Windows at least) - to match https://github.com/dotnet/coreclr/blob/master/clr.coreclr.props#L68.
|
Looks good to me otherwise. |
|
Thanks, I restored lazycow.cpp (and enabled the feature) and cleaned up a few more files. Do you know what's up with genericstackprobe.cpp (FEATURE_STACK_PROBE)? Doesn't seem to be used. |
|
|
|
OK, remove genericstackprobe.cpp as well. I've left in the following:
and disabled LNK4221 for static libraries (it was wrongly disabled for dlls). Fixes #2252 |
Some files have their contents ifdefed out because some CLR features (remoting, CAS, fusion etc.) are not present (and they'll probably never be) in CoreCLR. A few others are DAC, CrossGen or arch specific so they have been moved to the appropiate file lists.
|
Removed umthunkhash.cpp/typeequivalencehash.cpp and squashed. I also rebased against master, maybe the build will stop failing after you disabled those tests. |
Do not include unnecessary files in build
Linker warning 4221 was disabled in dotnet#2320 and was accidentally reenabled in dotnet#2244
Do not include unnecessary files in build Commit migrated from dotnet/coreclr@d889ba3
Linker warning 4221 was disabled in dotnet/coreclr#2320 and was accidentally reenabled in dotnet/coreclr#2244 Commit migrated from dotnet/coreclr@e99a813
Some files have their contents ifdefed out because some CLR features are not present (and they'll probably never be) in CoreCLR. A few others are DAC and/or arch specific so they have been moved to the appropiate file lists.