Nullable: Exception, SystemException, Argument*Exception#23515
Nullable: Exception, SystemException, Argument*Exception#23515safern merged 2 commits intodotnet:NullableFeaturefrom
Conversation
| } | ||
|
|
||
| public MethodBase TargetSite | ||
| public MethodBase? TargetSite |
There was a problem hiding this comment.
Exception.Message is another one we should add to the "should it be nullable" list (it wasn't changed in the PR so I can't comment on it). @safern, could you set up a meeting to work through it with all the relevant parties? We're going to hit more of these. I've never seen null returned from Message, though (whereas I have from ToString).
There was a problem hiding this comment.
Done! I think it makes sense to at least return an empty string from Exception.Message -- I don't think it makes sense to return null, but that takes us back to the same discussion of ToString. Let's discuss this on the meeting and hopefully we all agree on something in order to keep making progress.
There was a problem hiding this comment.
Going to merge as this one seems "clearer" to me that it shouldn't return null. However, we can revisit tomorrow in our meeting and fix if that is the case.
…clr#23515) * Nullable: Exception, SystemException, Argument*Exception * Add Debug.Assert rather than comment Commit migrated from dotnet/coreclr@aba605f
2 participants
No description provided.