Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Nullable: shared/System/Security #23623

Merged
krwq merged 5 commits intodotnet:NullableFeaturefrom
krwq:nullable-security
Apr 4, 2019
Merged

Nullable: shared/System/Security #23623
krwq merged 5 commits intodotnet:NullableFeaturefrom
krwq:nullable-security

Conversation

@krwq
Copy link
Copy Markdown
Member

@krwq krwq commented Apr 1, 2019

No description provided.

@krwq krwq requested review from buyaa-n, safern and tannergooding April 1, 2019 17:21
jkotas
jkotas reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/PermissionSet.cs Outdated
@krwq krwq mentioned this pull request Apr 1, 2019
Merged
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/SecureString.Unix.cs Outdated
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/SecureString.Windows.cs Outdated
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/VerificationException.cs
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/IPermission.cs
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/PermissionSet.cs Outdated
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/PermissionSet.cs Outdated
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/PermissionSet.cs Outdated
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/PermissionSet.cs Outdated
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/PermissionSet.cs Outdated
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/PermissionSet.cs Outdated
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/PermissionSet.cs Outdated
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/PermissionSet.cs Outdated
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/PermissionSet.cs Outdated
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/PermissionSet.cs Outdated
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/PermissionSet.cs Outdated
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/PermissionSet.cs Outdated
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/PermissionSet.cs Outdated
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/PermissionSet.cs Outdated
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/Principal/IIdentity.cs
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/Principal/IPrincipal.cs
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/SecurityElement.cs
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/SecurityElement.cs
stephentoub
stephentoub reviewed Apr 1, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/SecurityException.cs Outdated
@krwq krwq mentioned this pull request Apr 1, 2019
Merged
@terrajobst terrajobst requested a review from a team April 2, 2019 00:29
@krwq krwq force-pushed the nullable-security branch from 14b1946 to 5084922 Compare April 2, 2019 19:11
@krwq
Copy link
Copy Markdown
Member Author

krwq commented Apr 2, 2019

rebased to fix merge conflict with my own PRs which change IL

safern
safern reviewed Apr 3, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/SecureString.Unix.cs Outdated
safern
safern reviewed Apr 3, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/SecureString.Unix.cs Outdated
safern
safern reviewed Apr 3, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/SecureString.Unix.cs Outdated
safern
safern reviewed Apr 3, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/SecureString.Unix.cs Outdated
safern
safern reviewed Apr 3, 2019
View reviewed changes
Comment thread src/System.Private.CoreLib/shared/System/Security/VerificationException.cs Outdated
@krwq krwq merged commit 34f7e67 into dotnet:NullableFeature Apr 4, 2019
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corefx that referenced this pull request Apr 5, 2019
@krwq @dotnet-bot
Nullable: shared/System/Security (dotnet/coreclr#23623)
061e96d 
* Nullable: shared/System/Security

* fix windows

* address feedback

* IIIIdentity.Identity?

* apply feedback

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub pushed a commit to dotnet/corefx that referenced this pull request Apr 6, 2019
@krwq @stephentoub
Nullable: shared/System/Security (dotnet/coreclr#23623)
ed49d90 
* Nullable: shared/System/Security

* fix windows

* address feedback

* IIIIdentity.Identity?

* apply feedback

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corert that referenced this pull request Apr 9, 2019
@krwq @Anipik
Nullable: shared/System/Security (dotnet/coreclr#23623)
c4a5339 
* Nullable: shared/System/Security

* fix windows

* address feedback

* IIIIdentity.Identity?

* apply feedback

Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corert that referenced this pull request Apr 9, 2019
@krwq @Anipik
Nullable: shared/System/Security (dotnet/coreclr#23623)
5813cd3 
* Nullable: shared/System/Security

* fix windows

* address feedback

* IIIIdentity.Identity?

* apply feedback

Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/mono that referenced this pull request Apr 9, 2019
@krwq @Anipik
Nullable: shared/System/Security (dotnet/coreclr#23623)
0ff8956 
* Nullable: shared/System/Security

* fix windows

* address feedback

* IIIIdentity.Identity?

* apply feedback

Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Anipik pushed a commit to Dotnet-GitSync-Bot/corert that referenced this pull request Apr 9, 2019
@krwq @Anipik
Nullable: shared/System/Security (dotnet/coreclr#23623)
f10683c 
* Nullable: shared/System/Security

* fix windows

* address feedback

* IIIIdentity.Identity?

* apply feedback

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas pushed a commit to dotnet/corert that referenced this pull request Apr 10, 2019
@krwq @jkotas
Nullable: shared/System/Security (dotnet/coreclr#23623)
44b986d 
* Nullable: shared/System/Security

* fix windows

* address feedback

* IIIIdentity.Identity?

* apply feedback

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@krwq
Nullable: shared/System/Security (dotnet/coreclr#23623)
7f08ab5 
* Nullable: shared/System/Security

* fix windows

* address feedback

* IIIIdentity.Identity?

* apply feedback


Commit migrated from dotnet/coreclr@34f7e67
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergooding tannergooding Awaiting requested review from tannergooding

@buyaa-n buyaa-n Awaiting requested review from buyaa-n

3 more reviewers

@stephentoub stephentoub stephentoub left review comments

@jkotas jkotas jkotas left review comments

@safern safern safern approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@krwq @stephentoub @jkotas @safern