Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix Debug.Assert in GenericDelegateCache#23755

Merged
stephentoub merged 1 commit intodotnet:NullableFeaturefrom
safern:FixAssertFutureFactory
Apr 5, 2019
Merged

Fix Debug.Assert in GenericDelegateCache#23755
stephentoub merged 1 commit intodotnet:NullableFeaturefrom
safern:FixAssertFutureFactory

Conversation

@safern
Copy link
Copy Markdown
Member

@safern safern commented Apr 5, 2019

The Debug.Assert is not matching what we're casting the value to, nor the generic parameters. Causing the JIT Perf tests to fail in the PR to merge to master:

Assertion Failed

   at System.Threading.Tasks.GenericDelegateCache`2.<>c.<.cctor>b__4_2(Task`1 wrappedAntecedents, Object state)
   at System.Threading.Tasks.ContinuationResultTaskFromResultTask`2.InnerInvoke()
   at System.Threading.Tasks.Task.<>c.<.cctor>b__274_0(Object obj)
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
   at System.Threading.Tasks.Task.ExecuteEntryUnsafe(Thread threadPoolThread)
   at System.Threading.Tasks.Task.ExecuteFromThreadPool(Thread threadPoolThread)
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()

cc: @stephentoub @danmosemsft

@stephentoub stephentoub merged commit bd05029 into dotnet:NullableFeature Apr 5, 2019
@safern safern deleted the FixAssertFutureFactory branch April 5, 2019 01:38
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corefx that referenced this pull request Apr 5, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub pushed a commit to dotnet/corefx that referenced this pull request Apr 6, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corert that referenced this pull request Apr 9, 2019
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corert that referenced this pull request Apr 9, 2019
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/mono that referenced this pull request Apr 9, 2019
Signed-off-by: dotnet-bot <anirudhagnihotry098@gmail.com>
Anipik pushed a commit to Dotnet-GitSync-Bot/corert that referenced this pull request Apr 9, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas pushed a commit to dotnet/corert that referenced this pull request Apr 10, 2019
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants