This repository was archived by the owner on Jan 23, 2023. It is now read-only.
If a delegate type is a WinRT delegate or a WinRT-projected delegate, allow default marshalling.#23877
Merged
jkoritzinsky merged 1 commit intodotnet:masterfrom Apr 11, 2019
Conversation
… allow default marshalling.
AaronRobinsonMSFT
approved these changes
Apr 11, 2019
davmason
pushed a commit
to davmason/coreclr
that referenced
this pull request
Apr 27, 2019
… allow default marshalling. (dotnet#23877)
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
… allow default marshalling. (dotnet/coreclr#23877) Commit migrated from dotnet/coreclr@3271f50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we changed the behavior of delegate marshalling to disallow users to marshal to the old
_Delegateinterface from the Mscorlib TLB in #23738, I missed a corner case where we might be marshalling for a WinRT event but might not be in a WinRT marshalling scenario, such subscribing to theINotifyPropertyChanged.PropertyChangedevent. While I was working on cleaning up #23409, I found this bug.This change allows any delegates that are WinRT delegates or are projected to/from WinRT delegates to marshal by default rules.