This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Block usage of default interfaces feature in COM scenarios#23970
Merged
AaronRobinsonMSFT merged 6 commits intoApr 19, 2019
Conversation
Add additional test cases and move some CCW functions to a more consolidated layout.
davidwrighton
approved these changes
Apr 18, 2019
Member
davidwrighton
left a comment
davidwrighton
left a comment
There was a problem hiding this comment.
Changes to the type system look good. Changes to interop look fine to my somewhat unpracticed eye.
Member
Author
|
@davidwrighton et al Also note that I ran all COM tests through GCStress and verified no issues and manually confirmed no memory leaks during COM object activation. |
Member
Author
|
@dotnet-bot test Ubuntu arm Cross Checked crossgen_comparison Build and Test please |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…reclr#23970) * Block default interface usage in COM scenarios Add additional test cases and move some CCW functions to a more consolidated layout. Commit migrated from dotnet/coreclr@df6b6f6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block usage of default interfaces within a COM scenario. This accomplished by validating any interface that is being passed into the COM world only contains abstract methods.
Tests:
IUnknownIClassFactoryQueryInterface()fails when requesting an interface with non-abstract methodsFixes #15683
cc @MichalStrehovsky @davidwrighton @jkoritzinsky @jeffschwMSFT