This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Changing Math.Max, Math.Min, Math.MaxMagnitude, and Math.MinMagnitudeto propagate NaN inputs#24039
Merged
jkotas merged 1 commit intodotnet:masterfrom Apr 17, 2019
tannergooding:propagate-nan
Merged
Changing Math.Max, Math.Min, Math.MaxMagnitude, and Math.MinMagnitudeto propagate NaN inputs#24039jkotas merged 1 commit intodotnet:masterfrom tannergooding:propagate-nan
jkotas merged 1 commit intodotnet:masterfrom
tannergooding:propagate-nan
Conversation
… to propagate NaN inputs
Member
Author
|
The CoreFX side is here: dotnet/corefx#36935 |
jkotas
approved these changes
Apr 16, 2019
Member
Author
|
CC. @karelz as an FYI |
Member
|
Do we have tests to ensure this behavior? This is one of those behaviors that people come to rely on and shouldn't be regressed less someone's models become invalid. |
Member
Yes: dotnet/corefx#36935 |
Member
|
@Anipik Could you please check the mirror? |
|
Yes, there were some merge conflicts with mono. I resolved them and its up again. Sry for the delay |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
… to propagate NaN inputs (dotnet/coreclr#24039) Commit migrated from dotnet/coreclr@c5b2e71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves the CoreCLR side of https://github.com/dotnet/corefx/issues/36931