Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Tighten GC mode assertion for EventPipe::Enable() #24124

Merged
jkotas merged 1 commit into from
Apr 20, 2019
Merged

Tighten GC mode assertion for EventPipe::Enable() #24124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vm/diagnosticserver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ static DWORD WINAPI DiagnosticsServerThread(LPVOID lpThreadParameter)
{
NOTHROW;
GC_TRIGGERS;
MODE_ANY;
MODE_PREEMPTIVE;
PRECONDITION(lpThreadParameter != nullptr);
}
CONTRACTL_END;
Expand Down
4 changes: 2 additions & 2 deletions src/vm/eventpipe.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ EventPipeSessionID EventPipe::Enable(
{
THROWS;
GC_TRIGGERS;
MODE_ANY;
MODE_PREEMPTIVE;
PRECONDITION(circularBufferSizeInMB > 0);
PRECONDITION(profilerSamplingRateInNanoseconds > 0);
PRECONDITION(numProviders > 0 && pProviders != nullptr);
Expand Down Expand Up @@ -276,7 +276,7 @@ EventPipeSessionID EventPipe::Enable(
{
THROWS;
GC_TRIGGERS;
MODE_ANY;
MODE_PREEMPTIVE;
PRECONDITION(pSession != nullptr);
PRECONDITION(GetLock()->OwnedByCurrentThread());
}
Expand Down
2 changes: 1 addition & 1 deletion src/vm/eventpipefile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ EventPipeFile::EventPipeFile(StreamWriter *pStreamWriter) : FastSerializableObje
{
THROWS;
GC_TRIGGERS;
MODE_ANY;
MODE_PREEMPTIVE;
}
CONTRACTL_END;

Expand Down
4 changes: 2 additions & 2 deletions src/vm/eventpipeprotocolhelper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ void EventPipeProtocolHelper::StopTracing(IpcStream *pStream)
{
THROWS;
GC_TRIGGERS;
MODE_ANY;
MODE_PREEMPTIVE;
PRECONDITION(pStream != nullptr);
}
CONTRACTL_END;
Expand Down Expand Up @@ -118,7 +118,7 @@ void EventPipeProtocolHelper::CollectTracing(IpcStream *pStream)
{
THROWS;
GC_TRIGGERS;
MODE_ANY;
MODE_PREEMPTIVE;
PRECONDITION(pStream != nullptr);
}
CONTRACTL_END;
Expand Down
8 changes: 4 additions & 4 deletions src/vm/fastserializer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ IpcStreamWriter::IpcStreamWriter(uint64_t id, IpcStream *pStream) : _pStream(pSt
{
NOTHROW;
GC_TRIGGERS;
MODE_ANY;
MODE_PREEMPTIVE;
PRECONDITION(_pStream != nullptr);
}
CONTRACTL_END;
Expand Down Expand Up @@ -73,7 +73,7 @@ FileStreamWriter::FileStreamWriter(const SString &outputFilePath)
{
THROWS;
GC_TRIGGERS;
MODE_ANY;
MODE_PREEMPTIVE;
}
CONTRACTL_END;
m_pFileStream = new CFileStream();
Expand Down Expand Up @@ -126,7 +126,7 @@ FastSerializer::FastSerializer(StreamWriter *pStreamWriter) : m_pStreamWriter(pS
{
THROWS;
GC_TRIGGERS;
MODE_ANY;
MODE_PREEMPTIVE;
PRECONDITION(m_pStreamWriter != NULL);
}
CONTRACTL_END;
Expand Down Expand Up @@ -268,7 +268,7 @@ void FastSerializer::WriteFileHeader()
{
NOTHROW;
GC_NOTRIGGER;
MODE_ANY;
MODE_PREEMPTIVE;
}
CONTRACTL_END;

Expand Down