This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix bug in impGetStructAddr.#24126
Merged
Merged
Conversation
sandreenko
commented
Apr 19, 2019
| // stmt - a statement to insert; | ||
| // stmtBefore - an insertion point to insert "stmt" before. | ||
| // | ||
| inline void Compiler::impInsertStmtBefore(GenTreeStmt* stmt, GenTreeStmt* stmtBefore) |
Author
There was a problem hiding this comment.
This function and impInsertTreeBefore have only one use each. I think they will go away soon so that is why they do not need more checks/cleaning right now.
There was a problem hiding this comment.
I trust you on that - though this is a bit confusing and I would have asked for a few more comments otherwise ;-)
Author
|
PTAL @dotnet/jit-contrib |
CarolEidt
approved these changes
Apr 19, 2019
| // stmt - a statement to insert; | ||
| // stmtBefore - an insertion point to insert "stmt" before. | ||
| // | ||
| inline void Compiler::impInsertStmtBefore(GenTreeStmt* stmt, GenTreeStmt* stmtBefore) |
There was a problem hiding this comment.
I trust you on that - though this is a bit confusing and I would have asked for a few more comments otherwise ;-)
Author
|
Thanks @CarolEidt. The PR was updated to exclude the test. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fix bug in impGetStructAddr. Commit migrated from dotnet/coreclr@924d4fc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/coreclr/issues/24114.
Thanks @Kaliumhexacyanoferrat and @jkotas for reporting/analyzing this.
The bug was introduced by my change b2f0301. I have not found any similar places where we can hit it.
When I merge this PR I will drop the repro test, wait for several hours and merge it as a separate PR to avoid breaks in other active PRs due to bug in ADO testing that use different head commits for "build" and "test" jobs.