Cleanup some build files#24539
Conversation
Replace usage of __BuildArch with BuildArch
AaronRobinsonMSFT
added
area-Build
* NO MERGE *
| @@ -4,16 +4,24 @@ | |||
|
|
|||
| using System; | |||
There was a problem hiding this comment.
@dotnet/jit-contrib Can I get someone from the JIT team to sign off on this altered test? It has been timing out on ARM64-checked build. I attempted to reduce the runtime duration without changing the spirit of the test too much.
There was a problem hiding this comment.
I think #24174 should be reverted with this test change.
AaronRobinsonMSFT
removed
the
* NO MERGE *
| @@ -1,2066 +0,0 @@ | |||
| ;--------------------------------------------------------------- | |||
| ; This comment block added by the CLR dev team. | |||
There was a problem hiding this comment.
End of an era..do these not work anymore?
There was a problem hiding this comment.
I don’t know if this doesn’t work anymore, but Visual Studio has a new way of doing debug visualizers with natvis files so that we don’t have to change our VS installation. And WinDbg also supports them. https://docs.microsoft.com/en-us/visualstudio/debugger/create-custom-views-of-native-objects?view=vs-2019
There was a problem hiding this comment.
@danmosemsft These files are still supported, but .natvis files are now preferred. The issue with the AUTOEXP.DAT and native visualizers in general is that they are particularly sensitive to type layouts. As soon as one aspect of the type visualizer layout changes other aspects of the type visualizer can fail and AUTOEXP.DAT have a particularly poor diagnostic experience.
|
Timeout failures for some tests - non-obvious functional failures. |
* Remove OsEnvironment, PackagesDir, and CoreCLRBinDir properties * Replace usage of __BuildArch with BuildArch * Simplify test timing out on ARM64
* Remove OsEnvironment, PackagesDir, and CoreCLRBinDir properties * Replace usage of __BuildArch with BuildArch * Simplify test timing out on ARM64 Commit migrated from dotnet/coreclr@42a4b41
4 participants
No description provided.