Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Correctly locate Clang [Fixes 250]#251

Merged
mmitche merged 1 commit into
dotnet:masterfrom
shahid-pk:issue-243
Feb 13, 2015
Merged

Correctly locate Clang [Fixes 250]#251
mmitche merged 1 commit into
dotnet:masterfrom
shahid-pk:issue-243

Conversation

@shahid-pk
Copy link
Copy Markdown

Proposed for #250 and #243 Clang locating issues.

Comment thread build.sh Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The clang naming is not a general Linux problem. It is interesting that e.g. in my Ubuntu, all the llvm-xxx commands have the 3.5 suffix, but the clang doesn't.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so what would you suggest we do here ? check for both clang and clang-* for linux?.
clang is also clang-* , actually their are two versions of clang available on ubuntu clang 3.4 and clang 3.5, if you install clang 3.4 , you get clang and clang++ commands but if you download clang-3.5 you get clang-3.5 and clang++-3.5 . I have checked it but i may be wrong.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it seems like we need to do it that way.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@shahid-pk
Copy link
Copy Markdown
Author

@janvorli comments addressed .

@shahid-pk
Copy link
Copy Markdown
Author

extra commit squashed

@janvorli
Copy link
Copy Markdown
Member

LGTM, thanks for fixing it.

@mmitche
Copy link
Copy Markdown
Member

mmitche commented Feb 13, 2015

LGTM

mmitche added a commit that referenced this pull request Feb 13, 2015
Correctly locate Clang [Fixes 250]
@mmitche mmitche merged commit 16714ec into dotnet:master Feb 13, 2015
@shahid-pk shahid-pk deleted the issue-243 branch February 13, 2015 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants