This repository was archived by the owner on Jan 23, 2023. It is now read-only.
String test refresh#25948
Merged
Merged
Conversation
jkoritzinsky
added
area-Interop
test enhancement
AaronRobinsonMSFT
approved these changes
Aug 8, 2019
|
Hmm, how did |
stephentoub
pushed a commit
that referenced
this pull request
Aug 24, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Rewrite all LP*STR/BSTR/AnsiBSTR parameter/return type tests. * Add string-field-in-struct tests. * Add tests for UnmanagedType.ByValTStr. * Fix casing in name. * PR Feedback. * Fix AnsiBStr test. * Remove redundant cast. * 2-phase lookup compliance. SysFreeString -> CoreClrBStrFree. * Remove extra using * Remove extra space * Calling conventions.... Commit migrated from dotnet/coreclr@ef1b0f7
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite the string tests (excluding UTF8 and VBByRefStr) to share most of their managed and native implementations to reduce duplicated code. The managed code is now the only source of truth for all tests other than the
MatchFunctionName*tests, which use the function name as the source of truth.