This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Refactor BinaryReader.ReadChars using Span #26325
Merged
Merged
Conversation
Member
Author
|
This is additional refactoring on top of #26324 that won't be ported to release/3.0. |
jkotas
force-pushed
the
binaryreader-span
branch
from
f29760c to
38e7c00
Compare
Avoids unsafe code and makes the code simpler
jkotas
force-pushed
the
binaryreader-span
branch
from
38e7c00 to
e6326e8
Compare
Member
Author
|
This is ready for review. cc @carlossanlop @stephentoub |
stephentoub
reviewed
Sep 3, 2019
stephentoub
approved these changes
Sep 3, 2019
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Sep 3, 2019
Avoids unsafe code and makes the code simpler Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Sep 3, 2019
Avoids unsafe code and makes the code simpler Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub
pushed a commit
to dotnet/corefx
that referenced
this pull request
Sep 3, 2019
Avoids unsafe code and makes the code simpler Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/mono
that referenced
this pull request
Sep 4, 2019
Avoids unsafe code and makes the code simpler Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
added a commit
to dotnet/corert
that referenced
this pull request
Sep 4, 2019
Avoids unsafe code and makes the code simpler Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
vargaz
pushed a commit
to mono/mono
that referenced
this pull request
Sep 4, 2019
* Refactor BinaryReader.ReadChars using Span (dotnet/coreclr#26325) Avoids unsafe code and makes the code simpler Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com> * Remove unnecessary parens from `return (true);` and `return (false);` (#26488) Just a search and replace. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com> * Avoid some unnecessary initialization in DateTimeParse (#26487) Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com> * Update analyzer versions (dotnet/corefx#40778) In particular to pick up StyleCop fixes related to C# 8 and nullability. Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Avoids unsafe code and makes the code simpler Commit migrated from dotnet/coreclr@98d09ee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.