Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

di can be built, but still cannot be linked.#268

Merged
jkotas merged 1 commit into
dotnet:masterfrom
kangaroo:master
Feb 14, 2015
Merged

di can be built, but still cannot be linked.#268
jkotas merged 1 commit into
dotnet:masterfrom
kangaroo:master

Conversation

@kangaroo
Copy link
Copy Markdown

@kangaroo kangaroo commented Feb 14, 2015

No description provided.

jkotas added a commit that referenced this pull request Feb 14, 2015
@jkotas
Merge pull request #268 from kangaroo/master
9e2ceb3 
di can be built, but still cannot be linked.
@jkotas jkotas merged commit 9e2ceb3 into dotnet:master Feb 14, 2015
@janvorli
Copy link
Copy Markdown
Member

janvorli commented Feb 14, 2015

@kangaroo What was the problem? Some undefined symbols?

@kangaroo
Copy link
Copy Markdown
Author

kangaroo commented Feb 14, 2015

@janvorli Yes, the shared object is missing the debug transport implementation for unix. This causes a link failure on OS X, rather than a runtime failure.

Undefined symbols for architecture x86_64:
  "GetThreadId(_DEBUG_EVENT const*)", referenced from:
      ShimProcess::DefaultEventHandler(_DEBUG_EVENT const*, unsigned int*) in libcordbdi.a(shimprocess.cpp.o)
      ShimProcess::HandleWin32DebugEvent(_DEBUG_EVENT const*) in libcordbdi.a(shimprocess.cpp.o)
  "GetProcessId(_DEBUG_EVENT const*)", referenced from:
      CordbWin32EventThread::Win32EventLoop() in libcordbdi.a(process.cpp.o)
      ShimProcess::HandleWin32DebugEvent(_DEBUG_EVENT const*) in libcordbdi.a(shimprocess.cpp.o)
  "IsExceptionEvent(_DEBUG_EVENT const*, int*, _EXCEPTION_RECORD const**)", referenced from:
      ShimProcess::DefaultEventHandler(_DEBUG_EVENT const*, unsigned int*) in libcordbdi.a(shimprocess.cpp.o)
      ShimProcess::HandleWin32DebugEvent(_DEBUG_EVENT const*) in libcordbdi.a(shimprocess.cpp.o)
  "NewPipelineForThisPlatform()", referenced from:
      NewPipelineWithDebugChecks() in libcordbdi.a(nativepipeline.cpp.o)
  "NewEventChannelForThisPlatform(unsigned long, ICorDebugMutableDataTarget*, unsigned int, MachineInfo, IEventChannel**)", referenced from:
      CordbProcess::GetEventBlock(int*) in libcordbdi.a(process.cpp.o)
  "BuildPlatformSpecificDataTarget(MachineInfo, unsigned int, ShimDataTarget**)", referenced from:
      ShimProcess::InitializeDataTarget(unsigned int) in libcordbdi.a(shimprocess.cpp.o)
  "EventRedirectionPipeline::EventRedirectionPipeline()", referenced from:
      CreateEventRedirectionPipelineIfEnabled() in libcordbdi.a(nativepipeline.cpp.o)
  "vtable for UtilExecutionEngine", referenced from:
      UtilExecutionEngine::UtilExecutionEngine() in libutilcodestaticnohost.a(clrhost_nodependencies.cpp.o)
  NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.

ellismg pushed a commit to ellismg/coreclr that referenced this pull request Apr 14, 2015
Merge pull request dotnet#268 from peterblazejewicz/fix/compiler-warning
29acc23 
Refactor method to explicit helper. Fixes #253
franksinankaya added a commit to franksinankaya/coreclr that referenced this pull request Dec 11, 2019
@franksinankaya
Fix friend class declaration (dotnet#268)
3828efe 
[ 27%] Building CXX object src/pal/src/CMakeFiles/coreclrpal.dir/arch/amd64/signalhandlerhelper.cpp.o
coreclr/src/pal/src/thread/thread.cpp:1613:1: error: ‘CorUnix::PAL_ERROR CorUnix::InternalSetThreadDescription(CorUnix::CPalThread*, HANDLE, PCWSTR)’ has not been declared within CorUnix [-Werror]
 CorUnix::InternalSetThreadDescription(
 ^~~~~~~
In file included from coreclr/src/pal/src/include/pal/dbgmsg.h:160:0,
                 from coreclr/src/pal/src/thread/thread.cpp:21:
coreclr/src/pal/src/include/pal/thread.hpp:204:13: note: only here as a friend
             InternalSetThreadDescription(
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kangaroo @janvorli @jkotas @dnfclas