This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add "inline" labels and rename IGF_EMIT_ADD to IGF_EXTEND#26819
Merged
Conversation
sandreenko
reviewed
Sep 23, 2019
CarolEidt
approved these changes
Sep 23, 2019
CarolEidt
left a comment
CarolEidt
left a comment
There was a problem hiding this comment.
Other than function headers (as pointed out by @sandreenko ) and one comment request, LGTM
This flag conceptually represents that the instruction group extends the previous instruction group and means that the emitter will continue to track GC info as if there was no label.
jakobbotsch
force-pushed
the
extend-instruction-group
branch
from
dc3c064 to
fad30aa
Compare
BruceForstall
approved these changes
Sep 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag conceptually represents that the instruction group extends the
previous instruction group and means that the emitter will continue to
track GC info as if there was no new block.
@CarolEidt suggested I factor this change out of #26418.
cc @dotnet/jit-contrib