Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[CPAOT] Generating code for hardware intrinsic (#26772)#26982

Closed
cshung wants to merge 1 commit into
dotnet:single-exefrom
cshung:dev/andrewau/single-intrinsic
Closed

[CPAOT] Generating code for hardware intrinsic (#26772)#26982
cshung wants to merge 1 commit into
dotnet:single-exefrom
cshung:dev/andrewau/single-intrinsic

Conversation

@cshung
Copy link
Copy Markdown

@cshung cshung commented Oct 2, 2019

No description provided.

@MichalStrehovsky
Copy link
Copy Markdown
Member

Is there something in master that prevents us from doing a full integration? David did a full integration a week ago. There's not much stuff in master that is not in single-exe.

Cherry picking commits can cause merging trouble down the line. Especially because we expect to make changes in these lines soon.

@cshung
Copy link
Copy Markdown
Author

cshung commented Oct 2, 2019

Cherry picking commits can cause merging trouble down the line. Especially because we expect to make changes in these lines soon.

I was doing this cherry-pick PR just because Simon asked me to. To be honest I was thinking about rebase which is probably not what we wanted either. I will do a separate merge PR instead.

@cshung cshung closed this Oct 2, 2019
@cshung cshung deleted the dev/andrewau/single-intrinsic branch October 2, 2019 18:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants