This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Replace gtLclVarCommon. with AsLclVarCommon()->#27207
Merged
Merged
Conversation
franksinankaya
changed the title
franksinankaya
force-pushed
the
frkaya/gtLclVarCommon
branch
2 times, most recently
from
62f3185 to
bcb3953
Compare
…on()\./g' {} \;
gtLclVarCommon
franksinankaya
force-pushed
the
frkaya/gtLclVarCommon
branch
from
18294ce to
2656a2a
Compare
sandreenko
approved these changes
Oct 18, 2019
sandreenko
left a comment
sandreenko
left a comment
There was a problem hiding this comment.
LGTM, ignore the notes, but please delete the extra symbol in the license header.
| if ((init->gtOper != GT_ASG) || (init->AsOp()->gtOp1->gtOper != GT_LCL_VAR) || | ||
| (init->AsOp()->gtOp1->gtLclVarCommon.GetLclNum() != lvar) || (init->AsOp()->gtOp2->gtOper != GT_CNS_INT) || | ||
| (init->AsOp()->gtOp2->AsIntCon()->gtIconVal != lbeg) || | ||
| (init->AsOp()->gtOp1->AsLclVarCommon()->GetLclNum() != lvar) || |
| @@ -3727,7 +3727,8 @@ GenTreeCall* Compiler::fgMorphArgs(GenTreeCall* call) | |||
| assert(argEntry->structDesc.passedInRegisters); | |||
| if (lclVar != nullptr) | |||
|
|
||
| // Assign the ssa num for the use. Note it may be the reserved num. | ||
| cse->gtLclVarCommon.SetSsaNum(cseSsaNum); | ||
| cse->AsLclVarCommon()->SetSsaNum(cseSsaNum); |
| @@ -16435,7 +16436,8 @@ bool Compiler::impReturnInstruction(BasicBlock* block, int prefixFlags, OPCODE& | |||
| // Some other block(s) have seen the CEE_RET first. | |||
| // Better they spilled to the same temp. | |||
| assert(impInlineInfo->retExpr->gtOper == GT_LCL_VAR); | |||
| if ((arrayAssignment->gtOper != GT_ASG) || (arrayAssignment->AsOp()->gtOp1->gtOper != GT_LCL_VAR) || | ||
| (arrayLocalNode->gtOper != GT_LCL_VAR) || | ||
| (arrayAssignment->AsOp()->gtOp1->gtLclVarCommon.GetLclNum() != arrayLocalNode->gtLclVarCommon.GetLclNum())) | ||
| (arrayLocalNode->gtOper != GT_LCL_VAR) || (arrayAssignment->AsOp()->gtOp1->AsLclVarCommon()->GetLclNum() != |
franksinankaya
force-pushed
the
frkaya/gtLclVarCommon
branch
from
fa60750 to
c3b41dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sandreenko