This repository was archived by the owner on Jan 23, 2023. It is now read-only.
ARM32 compilation fixes with GCC #27795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franksinankaya
force-pushed
the
frkaya/armfixes
branch
from
c1f0a9b to
ff68c48
Compare
franksinankaya
changed the title
janvorli
reviewed
Nov 11, 2019
franksinankaya
force-pushed
the
frkaya/armfixes
branch
from
ff68c48 to
073aa95
Compare
franksinankaya
force-pushed
the
frkaya/armfixes
branch
from
073aa95 to
648a37e
Compare
Author
|
any other comments? |
|
ping @janvorli |
Author
|
@janvorli : any other feedback on this PR? |
MichalStrehovsky
pushed a commit
to MichalStrehovsky/corert
that referenced
this pull request
Mar 28, 2020
* Suppress on clang only * Fix integer conversion * Extra qualifier * Suppress warning * Extra qualifier * Signedness issues * Correct offsetof * Offsetof doesn't support non-constant values * Conversion errors * Move the comment too * Fix assembly warning * size is not constant * Fix comment type * Fix endmacro name * Use OFFSET_NONE constant Commit migrated from dotnet/coreclr@e8bbcf1
MichalStrehovsky
pushed a commit
to MichalStrehovsky/corert
that referenced
this pull request
Mar 31, 2020
* Suppress on clang only * Fix integer conversion * Extra qualifier * Suppress warning * Extra qualifier * Signedness issues * Correct offsetof * Offsetof doesn't support non-constant values * Conversion errors * Move the comment too * Fix assembly warning * size is not constant * Fix comment type * Fix endmacro name * Use OFFSET_NONE constant Commit migrated from dotnet/coreclr@e8bbcf1
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Apr 1, 2020
* Suppress on clang only * Fix integer conversion * Extra qualifier * Suppress warning * Extra qualifier * Signedness issues * Correct offsetof * Offsetof doesn't support non-constant values * Conversion errors * Move the comment too * Fix assembly warning * size is not constant * Fix comment type * Fix endmacro name * Use OFFSET_NONE constant Commit migrated from dotnet/coreclr@e8bbcf1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@am11 @jkotas @janvorli