This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Change from bin/Product and bin/tests/ to artifacts/Product and artifacts/tests/#27870
Closed
jashook wants to merge 1 commit intodotnet:masterfrom
Closed
Change from bin/Product and bin/tests/ to artifacts/Product and artifacts/tests/#27870jashook wants to merge 1 commit intodotnet:masterfrom
bin/Product and bin/tests/ to artifacts/Product and artifacts/tests/#27870jashook wants to merge 1 commit intodotnet:masterfrom
Conversation
… `artifacts/tests/` This change does not make us more arcadified; however, it does get us closer to using their layout.
jkoritzinsky
suggested changes
Nov 14, 2019
Member
jkoritzinsky
left a comment
jkoritzinsky
left a comment
There was a problem hiding this comment.
build.cmd also needs to be updated to point to artifacts instead of bin.
| displayName: Publish Logs | ||
| inputs: | ||
| pathtoPublish: $(coreClrRepoRoot)/bin/Logs | ||
| pathtoPublish: $(coreClrRepoRoot)/artifacts/Logs |
Member
There was a problem hiding this comment.
Arcade uses lowercase-L artifacts/logs instead of capital-L Logs.
jashook
added
the
* NO MERGE *
Member
|
I would like to see this being ported and merged into the runtime repo before we open it up for others. As a manual port either on Friday or me over the weekend.. |
Author
|
Ported dotnet/runtime#51 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change does not make us more arcadified; however, it does get us closer to using their layout.
I do not expect this to make the consolidation deadline. @ViktorHofer @jkoritzinsky @trylek ptal