This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix build breaks in Linux ARM port#2935
Merged
Merged
Conversation
Member
Author
Member
Author
|
@ramarag Could you please take a look? |
jkotas
force-pushed
the
arm-fixes
branch
2 times, most recently
from
c0de392 to
81fd0f0
Compare
- Delete left-over cruft from internal build - Move Windows-specific defines under WIN32
|
FEATURE_EVENT_TRACE stuff LGTM. armv7 stuff looks GTM, but I haven't bootstrapped it locally. |
|
LGTM on a quick glance, I will try and build this locally tomorrow. On Sun, 31 Jan 2016, 06:01 Geoff Norton notifications@github.com wrote:
|
Member
|
FEATURE_EVENT_TRACE changes LGTM |
Turn FEATURE_EVENT_TRACE on for x64 Linux only. aarch64 and arm do not have working lttng in their ubuntu/debian repos. We can expand to other platforms in the future as they become supported.
jkotas
added a commit
that referenced
this pull request
Jan 31, 2016
Fix build breaks in Linux ARM port
Member
|
@jkotas how big of an SD card do you recommend? |
Member
Author
|
8GB was not enough for Raspbian + CoreCLR build. 16GB should be enough. If you are buying a new SD card, I would recommend 64GB - it is where the best $/GB point seems to be these days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are likely more fixes required ... waiting for a new SSD card for my Raspberry Pi2 to arrive.