This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix unwinding past main on OSX#509
Closed
kangaroo wants to merge 1 commit into
Closed
Conversation
unw_step is defined to return 0 when it hits the bottom. The current code assumes a non-osx-libunwind specific behavior of a null $pc coming back from the cursor. The correct behavior is to return when the step fails, and dump the exception to the console.
Author
|
This PR isn't correct as it is. I'm going to open an issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unw_step is defined to return 0 when it hits the bottom.
The current code assumes a non-osx-libunwind specific behavior
of a null $pc coming back from the cursor. The correct behavior
is to return when the step fails, and dump the exception to
the console.
Currently any test that throws through main ends up in an infinite loop on OSX.