This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix statement insertion point in GT_STORE_LCL_VAR decomposition#5923
Merged
Conversation
In some cases a newly created statement is inserted between the current statement and its embedded statements instead of being inserted after the current statement and its embedded statements.
|
/cc @dotnet/jit-contrib Mike, does it make sense to add the test case from #5696 as a regression test along with this fix? |
Author
Yep, I'll add it. I forgot that I specifically wrote it to avoid problems with x86 casts and thought that it would fail despite this fix. |
|
LGTM. |
|
Thanks for adding the test case. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fix statement insertion point in GT_STORE_LCL_VAR decomposition Commit migrated from dotnet/coreclr@b1aa2c1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases a newly created statement is inserted between the current statement and its embedded statements instead of being inserted after the current statement and its embedded statements.
Fixes #5696
In addition to the fix itself I reorganized the code to be similar to the code used by @sejongoh in #5380. We should be able to extract a common function from this when the decomposition story is in a better shape.