Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Generate nuget packages for Arm64 build#6000

Merged
gkhanna79 merged 2 commits into
dotnet:masterfrom
gkhanna79:Arm64Nuget
Jun 29, 2016
Merged

Generate nuget packages for Arm64 build#6000
gkhanna79 merged 2 commits into
dotnet:masterfrom
gkhanna79:Arm64Nuget

Conversation

@gkhanna79
Copy link
Copy Markdown
Member

@gkhanna79
Copy link
Copy Markdown
Member Author

@gkhanna79
Copy link
Copy Markdown
Member Author

@dotnet-bot test Windows_NT arm64 Checked

@gkhanna79
Copy link
Copy Markdown
Member Author

@dotnet-bot test Windows_NT arm64 Release

@gkhanna79
Copy link
Copy Markdown
Member Author

@dotnet-bot test Windows_NT arm64 Checked please

@gkhanna79
Copy link
Copy Markdown
Member Author

@dotnet-bot test Windows_NT arm64 Release please

@rahku
Copy link
Copy Markdown

rahku commented Jun 27, 2016

Thanks. native arm64 crossgen seems missing from the package. If it is not placed in the package we will lose it or it needs to be re-built everytime we need it.

@gkhanna79
Copy link
Copy Markdown
Member Author

native arm64 crossgen seems missing from the package.

For now, I have intentionally kept it out since it is not expected to be used in production scenarios (i.e. we expect to generate native images in cross-compilation scenario and the crossgen under tools\x64_arm64 should suffice).

Is there a specific scenario you have in mind?

@rahku
Copy link
Copy Markdown

rahku commented Jun 27, 2016

Yes in order to be able to run R2R tests on the device we need native crossgen because crossgen is run as part of runtests.cmd

@rahku
Copy link
Copy Markdown

rahku commented Jun 27, 2016

Should be also required to run R2R helix runs on the target.

@gkhanna79
Copy link
Copy Markdown
Member Author

@dotnet-bot test Windows_NT arm64 Checked please

@gkhanna79
Copy link
Copy Markdown
Member Author

@rahku Sounds good. I have added native crossgen to the package as well.

<SkipPackageFileCheck>true</SkipPackageFileCheck>
<SkipValidatePackage>true</SkipValidatePackage>
<PackagePlatforms>x64;x86;arm</PackagePlatforms>
<PackagePlatforms>x64;x86;arm64;arm</PackagePlatforms>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

orthogonal but something I notices while reviewing. This claims to support arm but I don't see an arm configuration below.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think it claims to support arm per https://github.com/dotnet/buildtools/blob/3c700d1ecc358c6c1b3ffbaaeb49e7864a8e9ba7/src/Microsoft.DotNet.Build.Tasks.Packaging/src/PackageFiles/Packaging.targets#L125 which expects a trailing ";" to enable the platform.

That said, I will be looking into enabling Arm32 once I am done with this.

@weshaggard
Copy link
Copy Markdown
Member

LGTM

1 similar comment
@rahku
Copy link
Copy Markdown

rahku commented Jun 28, 2016

LGTM

@gkhanna79 gkhanna79 merged commit d72f936 into dotnet:master Jun 29, 2016
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Generate nuget packages for Arm64 build

Commit migrated from dotnet/coreclr@d72f936
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants