Generate nuget packages for Arm64 build#6000
Conversation
|
@dotnet-bot test Windows_NT arm64 Checked |
|
@dotnet-bot test Windows_NT arm64 Release |
|
@dotnet-bot test Windows_NT arm64 Checked please |
|
@dotnet-bot test Windows_NT arm64 Release please |
|
Thanks. native arm64 crossgen seems missing from the package. If it is not placed in the package we will lose it or it needs to be re-built everytime we need it. |
For now, I have intentionally kept it out since it is not expected to be used in production scenarios (i.e. we expect to generate native images in cross-compilation scenario and the crossgen under tools\x64_arm64 should suffice). Is there a specific scenario you have in mind? |
|
Yes in order to be able to run R2R tests on the device we need native crossgen because crossgen is run as part of runtests.cmd |
|
Should be also required to run R2R helix runs on the target. |
|
@dotnet-bot test Windows_NT arm64 Checked please |
|
@rahku Sounds good. I have added native crossgen to the package as well. |
| <SkipPackageFileCheck>true</SkipPackageFileCheck> | ||
| <SkipValidatePackage>true</SkipValidatePackage> | ||
| <PackagePlatforms>x64;x86;arm</PackagePlatforms> | ||
| <PackagePlatforms>x64;x86;arm64;arm</PackagePlatforms> |
There was a problem hiding this comment.
orthogonal but something I notices while reviewing. This claims to support arm but I don't see an arm configuration below.
There was a problem hiding this comment.
I dont think it claims to support arm per https://github.com/dotnet/buildtools/blob/3c700d1ecc358c6c1b3ffbaaeb49e7864a8e9ba7/src/Microsoft.DotNet.Build.Tasks.Packaging/src/PackageFiles/Packaging.targets#L125 which expects a trailing ";" to enable the platform.
That said, I will be looking into enabling Arm32 once I am done with this.
|
LGTM |
1 similar comment
|
LGTM |
Generate nuget packages for Arm64 build Commit migrated from dotnet/coreclr@d72f936
@weshaggard @ericstj @pgavlin @rahku PTAL
CC @haripulapaka