This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Further optimizations for String.Join, String.Concat#6800
Merged
Conversation
Member
There was a problem hiding this comment.
I do not think that this optimization is worth the extra code.
Author
|
@jasonwilliams200OK I have opened up a pull request in your fork which I believe should remove the merge conflicts with this PR. |
Author
|
@jkotas Is this OK to be merged? I will port the changes to the CoreRT repo if it's ready. |
Member
|
LGTM. Thanks! |
ghost
mentioned this pull request
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…6800) * Apply length-1 optimization to Join(string, object[]) * Apply length-1 optimization to Concat(IEnumerable<string>) * Apply length-1 optimization to Concat(IEnumerable<T>) * Apply lengths 0/1 optimizations to Concat(object[]), Concat(string[]) Commit migrated from dotnet/coreclr@d39efa7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
IEnumerable<string>based overload in the generic overloads, iftypeof(T) == typeof(string). This can happen practically if someone has aGenericMethod<T>that calls Concat/Join, and then someone calls that method with T == string.cc @jkotas, @bbowyersmyth
Tests are dotnet/corefx#10966