This repository was archived by the owner on Jan 23, 2023. It is now read-only.
SpinLock.TryEnter fail fast for timeout 0#6911
Closed
benaadams wants to merge 4 commits into
Closed
Conversation
| // Lock owned, haven't acquired the lock | ||
| if (millisecondsTimeout == 0) | ||
| { | ||
| // If timeout is zero fail fast, don't update waiters, don't spin to attempt acquire, exit |
Member
There was a problem hiding this comment.
Nit: missing comma after "If timeout is zero"
Member
Author
|
Closing for now while I work through the flow a bit more. |
eb8bdbd to
f361190
Compare
a5b09fb to
5967b70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes corefx tests
1M iters (single thread, uncontended but locked) for code
Need to do the threadpool timing tests I have (on a couple environments), as TrySteal uses this path; and they introduce parallel contention. Hopefully will improve, but will see.
Also corrected some strange spellings.