Upgrade CLI, buildtools for RTM shared framework#7045
Conversation
|
There are some issues I'm working through in the corefx PR first: dotnet/corefx#11387. I'll push a fix here after I make sure the corefx one works. |
dagood
force-pushed
the
upgrade-buildtools
branch
from
7d73882 to
66573a8
Compare
|
@dotnet-bot test OSX x64 Checked Build and Test (went offline) |
| fi | ||
|
|
||
| __CLIDownloadURL=https://dotnetcli.blob.core.windows.net/dotnet/preview/Binaries/${__DOTNET_TOOLS_VERSION}/${__DOTNET_PKG}.${__DOTNET_TOOLS_VERSION}.tar.gz | ||
| __CLIDownloadURL=https://dotnetcli.blob.core.windows.net/dotnet/Sdk/${__DOTNET_TOOLS_VERSION}/${__DOTNET_PKG}.${__DOTNET_TOOLS_VERSION}.tar.gz |
There was a problem hiding this comment.
You can use our CDN now: https://dotnetcli.azureedge.net/dotnet instead of https://dotnetcli.blob.core.windows.net/dotnet. This results in faster downloads for people in other locations.
There was a problem hiding this comment.
Also - do we have a bug to track using the dotnet-install scripts instead of doing it manually here? To install the CLI, it is a lot less code if you use the dotnet-install script.
There was a problem hiding this comment.
Interesting about the CDN, if this gets through CI and is ok to merge I'd like to do that in another round of PRs just so these changes can get though.
About removing the duplication, that's discussed here: dotnet/core-setup#254 (comment). In short: that'll happen and more, but I don't know where/if it's tracked. /cc @jhendrixMSFT
|
@dotnet-bot test this please |
|
@dagood Is this good to merge? |
|
@jkotas I think it is. I didn't get any LGTMs in coreclr, but these changes have been working fine in other repos. (It'll also unblock master from taking buildtools updates.) |
5 participants
See dotnet/corefx#11387. This buildtools change requires a CLI update at the same time, so I'm pushing it through to avoid pain later.
/cc @gkhanna79 @wtgodbe @weshaggard