This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Adding missing String members to coreclr#7142
Merged
Merged
Conversation
| public CharEnumerator GetEnumerator() { | ||
| Contract.Ensures(Contract.Result<CharEnumerator>() != null); | ||
| Contract.EndContractBlock(); | ||
| BCLDebug.Perf(false, "Avoid using String's CharEnumerator until C# special cases foreach on String - use the indexed property on String instead."); |
Member
There was a problem hiding this comment.
What does this Perf call do? Is it an assert? I'm wondering if we need to remove it.
Member
Author
There was a problem hiding this comment.
I also thought it might be like an assert, if you see we also have it in some other already public members like line 864 or 872 of this same file, so I doubt that we have to do anything special. @weshaggard do you know if we have to remove that line?
Member
There was a problem hiding this comment.
I'm not sure what that actually does.
Member
|
LGTM |
Member
Author
|
In order for CI to pass, I had to remove member: since it depends on ArgIterator which we still don't know if we are going to port or not. |
Member
|
FYI @tarekgh looks like the string.GetEnumerator() method is exposed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @stephentoub @weshaggard
Adding missing members to String.
related issue: dotnet/corefx#10216